Skip to content

Add @bharath-techie as maintainer #18556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

shwetathareja
Copy link
Member

Following the nomination process, I have nominated and other maintainers have agreed to add bharath-techie as a co-maintainer of the OpenSearch repository. He has kindly accepted the invitation.

Bharath has authored 35 issues including 4 RFCs, merged 62 PRs and reviewed 83 PRs for others. Bharath has been an active contributor to OpenSearch since 2022 and his most recent notable contribution has been the innovative Star Tree data structure in OpenSearch core. He has demonstrated strong technical depth and ownership by the driving Star Tree index idea from inception, driving discussions with both Lucene and OpenSearch community, implementing and releasing it as experimental feature in 2.18. He has contributed to multiple other complex and deep features of OpenSearch like Point in Time Search, Admission Control Framework and Async search. He is also maintainer in the asynchronous-search repository and has notable contributions with 40 PRs merged and reviewed 80 PRs for others. He is actively engaged in community meeting for Indexing area. He recently presented Analytics Performance at Scale : The OpenSearch Star Tree Index Journey in OpenSearchCon Europe 2025 and also presented “Accelerating aggregations using star tree index” topic in OpenSearchCon India 2024.

Some of his key highlights:

RFC
[RFC] Pre Compute Aggregations with Star Tree index
[RFC] Admission Controller framework for OpenSearch
[AdmissionControl] Using threadcontext to collect resource usage stats
[Design proposal] Point in time search

Features

Star Tree Index

  1. [Star tree] Star tree index configuration via mappings [Star tree] Star tree index configuration via mappings #14386]
  2. [Star tree] Star tree codec changes [Star tree] Star tree codec changes #14387]
  3. [Star tree] Star tree merge changes [Star tree] Star tree merge changes #14626]
  4. [Star tree] star tree off heap changes [Star tree] star tree off heap changes #14815]
  5. [Feature Request] Support for keyword fields as part of star tree index mapping [Feature Request] Support for keyword fields as part of star tree index mapping #16232
  6. [Star tree] Rounding off date field in Star tree [Star tree] Rounding off date field in Star tree #15265]

Reviewed all star-tree related PRs tracked in meta
Point in Time

  1. Create Point-In-Time Service Layer Changes
  2. Create Point-In-Time API Changes
  3. Delete Point-In-Time Service Layer Changes
  4. Delete Point-In-Time API Changes
  5. List all Point-In-Time Service Layer Changes
  6. List all Point-In-Time API Changes

Admission Control

  1. Proposed transport layer admission control framework and the design helped solved existing issues such as cluster manager admission control.
  2. Proposed threadcontext based resource usage collection to enable admission control in coordinator node and also proposed ranking / rejection enhancements for Search flows based on the same.
    Bugs Identified
  3. [BUG] Force merge in 3.0 OS is slower than 2.19 OS - issue - It was a great find requiring multi week investigation
  4. Identified degraded performance of main branch compared to 2.x which got fixed - issue
  5. Raised issue to disable _id field which will help customers mistakenly hitting heap limits
    Community Engagement
  6. [BUG] Page size calculation with Point-in-Time Pagination with Search Slicing
  7. [Feature Request] Tie breaker for search with search_after pagination
  8. [Explanation] max_open_pit_context
  9. Retrieve the total hits value that is locked during the PIT creation
  10. [BUG] Scroll API returns a recently deleted doc
  11. [ Asynchronous search ] Segment replication compatibility

Looking at his long list of contributions, Bharath will be very valuable as an OpenSearch maintainer.

@shwetathareja shwetathareja requested a review from a team as a code owner June 19, 2025 10:46
Signed-off-by: Shweta Thareja <[email protected]>
@shwetathareja
Copy link
Member Author

@peterzhuamazon can you please help here

Created - opensearch-project/.github#347

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shwetathareja please also add @bharath-techie in the .github/CODEOWNERS file before merging this PR.

I have added her as part of the maintainters team for OpenSearch core now.

Thanks.

@gbbafna gbbafna marked this pull request as ready for review June 20, 2025 03:06
@gbbafna
Copy link
Contributor

gbbafna commented Jun 20, 2025

@peterzhuamazon : would you be merging it post adding the permissions ?

I see that he is already added to maintainers , hence merging it .

@gbbafna gbbafna merged commit ef6cc26 into opensearch-project:main Jun 20, 2025
35 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.19 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.19
# Create a new branch
git switch --create backport/backport-18556-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ef6cc266ee180f892db07b551343243aca7601f5
# Push it to GitHub
git push --set-upstream origin backport/backport-18556-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.19

Then, create a pull request where the base branch is 2.19 and the compare/head branch is backport/backport-18556-to-2.19.

@shwetathareja
Copy link
Member Author

Hi @shwetathareja please also add @bharath-techie in the .github/CODEOWNERS file before merging this PR.

Sure @peterzhuamazon I will add him in CODEOWNERS as well. Thank you!

neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
Signed-off-by: Shweta Thareja <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants